(new to javascript) how to fix this code

This is the code

function onCollisionBetweenSprites() {

if (sprite.x === sprite2.x && sprite.y === sprite2.y ) {

wood += 1;

}

}

is there a mistake here?

im trying to make some code to destroy sprite 2 when sprite 1 touches it

if (sprite.x === sprite2.x && sprite.y === sprite2.y )

You are comparing if their origins are exactly overlapping. This is extremely unlikely to ever be true. You should use testOverlap instead, see

construct.net/en/make-games/manuals/construct-3/scripting/scripting-reference/object-interfaces/iworldinstance

I also recommend checking out the javascript examples since they'll cover most of the basic cases like that.

> if (sprite.x === sprite2.x && sprite.y === sprite2.y )

You are comparing if their origins are exactly overlapping. This is extremely unlikely to ever be true. You should use testOverlap instead, see

https://www.construct.net/en/make-games/manuals/construct-3/scripting/scripting-reference/object-interfaces/iworldinstance#internalH1Link3

I also recommend checking out the javascript examples since they'll cover most of the basic cases like that.

hey so i changed my script but still doesnt work

function onCollisionBetweenSprites(Sprite, sprite2) {

if (sprite.testOverlap(sprite2));

{

wood + 1

destroy,sprite2

}

}

onCollisionBetweenSprites;

this my new script

That doesn't look like valid JavaScript code.

If you are new to JavaScript coding I'd recommend going through the Learn JavaScript in Construct tutorial series, which will help you get the basics right.

That doesn't look like valid JavaScript code.

If you are new to JavaScript coding I'd recommend going through the Learn JavaScript in Construct tutorial series, which will help you get the basics right.

THANK YOU SO MUCH!

Ashley I've finish some of "learn javascript" but im still confused on how to make a collision code